Skip to content

Bump @xmldom/xmldom from 0.7.5 to 0.7.6#794

Merged
cjbarth merged 1 commit intomasterfrom
dependabot/npm_and_yarn/xmldom/xmldom-0.7.6
Oct 25, 2022
Merged

Bump @xmldom/xmldom from 0.7.5 to 0.7.6#794
cjbarth merged 1 commit intomasterfrom
dependabot/npm_and_yarn/xmldom/xmldom-0.7.6

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 17, 2022

Bumps @xmldom/xmldom from 0.7.5 to 0.7.6.

Release notes

Sourced from @​xmldom/xmldom's releases.

0.7.6

Commits

Fixed

Thank you, @​jftanner, @​Supraja9726 for your contributions

Changelog

Sourced from @​xmldom/xmldom's changelog.

0.7.6

Fixed

Thank you, @​jftanner, @​Supraja9726 for your contributions

0.8.3

Fixed

Thank you, @​Supraja9726 for your contributions

0.9.0-beta.2

Fixed

Thank you, @​Supraja9726 for your contributions

0.8.3

Fixed

Thank you, @​Supraja9726 for your contributions

0.9.0-beta.1

Fixed

Only use HTML rules if mimeType matches [#338](https://github.com/xmldom/xmldom/issues/338), fixes [#203](https://github.com/xmldom/xmldom/issues/203)

In the living specs for parsing XML and HTML, that this library is trying to implement, there is a distinction between the different types of documents being parsed: There are quite some rules that are different for parsing, constructing and serializing XML vs HTML documents.

So far xmldom was always "detecting" whether "the HTML rules should be applied" by looking at the current namespace. So from the first time an the HTML default namespace (http://www.w3.org/1999/xhtml) was found, every node was treated as being part of an HTML document. This misconception is the root cause for quite some reported bugs.

BREAKING CHANGE: HTML rules are no longer applied just because of the namespace, but require the mimeType argument passed to DOMParser.parseFromString(source, mimeType) to match 'text/html'. Doing so implies all rules for handling casing for tag and attribute names when parsing, creation of nodes and searching nodes.

BREAKING CHANGE: Correct the return type of DOMParser.parseFromString to Document | undefined. In case of parsing errors it was always possible that "the returned Document" has not been created. In case you are using Typescript you now need to handle those cases.

BREAKING CHANGE: The instance property DOMParser.options is no longer available, instead use the individual readonly property per option (assign, domHandler, errorHandler, normalizeLineEndings, locator, xmlns). Those also provides the default value if the option was not passed. The 'locator' option is now just a boolean (default remains true).

BREAKING CHANGE: The following methods no longer allow a (non spec compliant) boolean argument to toggle "HTML rules":

  • XMLSerializer.serializeToString
  • Node.toString

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot
Bump @xmldom/xmldom from 0.7.5 to 0.7.6
de78a69 
Bumps [@xmldom/xmldom](https://github.com/xmldom/xmldom) from 0.7.5 to 0.7.6.
- [Release notes](https://github.com/xmldom/xmldom/releases)
- [Changelog](https://github.com/xmldom/xmldom/blob/master/CHANGELOG.md)
- [Commits](xmldom/xmldom@0.7.5...0.7.6)

---
updated-dependencies:
- dependency-name: "@xmldom/xmldom"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Oct 17, 2022
@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Merging #794 (de78a69) into master (b67c144) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #794   +/-   ##
=======================================
  Coverage   65.10%   65.10%           
=======================================
  Files           4        4           
  Lines         149      149           
  Branches       37       37           
=======================================
  Hits           97       97           
  Misses         29       29           
  Partials       23       23

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@boldchains
Copy link

boldchains commented Oct 21, 2022

Hi, passport-saml team.
Would you please make another release for this, we are using passport-smal, and got a critical security alert.

markstos
markstos approved these changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@markstos markstos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but should we go ahead and bump to 0.8.3 instead of 0.7.6? It looks like both versions are patched.

@boldchains
Copy link

boldchains commented Oct 24, 2022

Thanks @markstos , please let me know when it's patched.

@markstos
Copy link
Contributor

markstos commented Oct 25, 2022

@boldchains You can subscribe to release notifications if you'd like those. I don't provide a personal release notification service.

@cjbarth
Copy link
Collaborator

cjbarth commented Oct 25, 2022

This looks good, but should we go ahead and bump to 0.8.3 instead of 0.7.6? It looks like both versions are patched.

I'll update all of that when I release 4.0. I'm shooting for this week.

@cjbarth cjbarth merged commit 7e93129 into master Oct 25, 2022
@cjbarth cjbarth deleted the dependabot/npm_and_yarn/xmldom/xmldom-0.7.6 branch October 25, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markstos markstos markstos approved these changes

+1 more reviewer

@boldchains boldchains boldchains approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@boldchains @markstos @cjbarth