Expose ValidateInResponseTo as it is required in options#220
Expose ValidateInResponseTo as it is required in options#220cjbarth merged 2 commits intonode-saml:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #220 +/- ##
==========================================
+ Coverage 80.70% 80.75% +0.04%
==========================================
Files 11 11
Lines 819 821 +2
Branches 251 251
==========================================
+ Hits 661 663 +2
Misses 68 68
Partials 90 90
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@ghusse , even though I merged this, please see some of these other linked PRs and offer your comments. There seems to be a bit of discussion around types and I want to make sure your experience it taken into account. |
|
Ok, thanks. I'll take a look. Let me know when the new version will be released, I'll probably need to make another change on |
|
I will land this and do releases once we figure out what the best approach forward is. It does seem though that if we stop exporting everything, then it will have to wait to be a semver-major change. If we just add to and re-work the exports, we can keep it as a semver-minor change; we can always remove the extra exports with v5 Q1 2023. |
Description
Options required by
passport-samlwhen creating a new configuration require the propertyvalidateInResponseToto use the enumValidateInResponseTo. But this enum is not easily accessible in@node-saml/passport-saml.In typescript, we need to import
@node-saml/node-saml/lib/typesto use this enum, which requires to add the dependency to@node-saml/node-samlto a project that would only require@node-saml/passport-saml.By exposing this enum in
node-saml, it'll be also exposed bypassport-samlonce updated to the latest version of its dependency.Checklist: