Skip to content

Editor loading improvements#5541

Merged
knolleary merged 18 commits intodevfrom
design-88-editor-loading
Mar 10, 2026
Merged

Editor loading improvements#5541
knolleary merged 18 commits intodevfrom
design-88-editor-loading

Conversation

@Steve-Mcl
Copy link
Copy Markdown
Contributor

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Discussed in issue #5509 and Design Node #88

closes #5509

Proposed changes

Improve editor loading speeds by reducing vendors budle size and loading code editors async.

Please refer to Design Node #88 for finer detail

TLDR

  • Remove ACE from vendors bundle
    • add vendor/ace/ace-bootstrap.js to load it only when set in settings.js
  • Load monaco (and ace) async (by adding script element to DOM in the bootstrap)
    • This removes document.write violations
  • Adds a basic (textarea) code editor as a fallback for late loading of editor (and usable alternative code editor for mad people)

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run npm run test to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@Steve-Mcl Steve-Mcl requested a review from knolleary March 7, 2026 10:24
@knolleary knolleary merged commit 78660d4 into dev Mar 10, 2026
5 checks passed
@knolleary knolleary deleted the design-88-editor-loading branch March 10, 2026 10:56
@knolleary knolleary linked an issue Mar 10, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Editor Loading Improvements

2 participants