Skip to content

[5522] UX: vertical scrollbar should not overlap subflow toolbar #5537

Merged
knolleary merged 2 commits intonode-red:devfrom
n-lark:5522-subflow-toolbar-scroll
Mar 9, 2026
Merged

[5522] UX: vertical scrollbar should not overlap subflow toolbar #5537
knolleary merged 2 commits intonode-red:devfrom
n-lark:5522-subflow-toolbar-scroll

Conversation

@n-lark
Copy link
Copy Markdown
Contributor

@n-lark n-lark commented Mar 6, 2026

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

Resolves #5522
Full change set and test plan here: #5522 (comment)

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run npm run test to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@knolleary
Copy link
Copy Markdown
Member

Should we make this adjustment earlier in the function as it will change the scrollbar height which impacts the calculations for the scroll handle size/position.

@knolleary knolleary linked an issue Mar 9, 2026 that may be closed by this pull request
Copy link
Copy Markdown
Member

@knolleary knolleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The adjustment to the top needs to be made above line 507 where we get the height of the scrollbar.

@n-lark
Copy link
Copy Markdown
Contributor Author

n-lark commented Mar 9, 2026

Hey @knolleary updated, thank you!

@knolleary knolleary merged commit e10bf6e into node-red:dev Mar 9, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UX: vertical scrollbar should not overlap subflow toolbar

2 participants