Skip to content

136 - Update color of inactive tabs to not appear disabled#5510

Merged
knolleary merged 3 commits intonode-red:sidebar-reduxfrom
n-lark:136-sidebar-redux-inactive-tabs
Mar 4, 2026
Merged

136 - Update color of inactive tabs to not appear disabled#5510
knolleary merged 3 commits intonode-red:sidebar-reduxfrom
n-lark:136-sidebar-redux-inactive-tabs

Conversation

@n-lark
Copy link
Copy Markdown
Contributor

@n-lark n-lark commented Mar 3, 2026

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

Resolves https://github.com/FlowFuse/node-red/issues/136

Full change set & manual testing plan here.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run npm run test to verify the unit tests pass

We have an early return in sidebar.js but not introduced by my changes, appears intentional. Just noting it here.

   packages/node_modules/@node-red/editor-client/src/js/ui/sidebar.js
    408 |            let tabBarButtonsBottom = tabBarButtonsContainer.position().top + tabBarButtonsContainer.outerHeight();
                     ^ Unreachable 'let' after 'return'.

>> 1 error in 92 files
  • I have added suitable unit tests to cover the new/changed functionality

@knolleary
Copy link
Copy Markdown
Member

knolleary commented Mar 3, 2026

Looks great. A couple edge cases to refine:

image
  1. If the flow name is very long, I think there ought to be a bit of padding on the LH edge
  2. In the case of a subflow with a long name, the icon is getting pushed off the edge of the tab

@n-lark
Copy link
Copy Markdown
Contributor Author

n-lark commented Mar 3, 2026

Hey @knolleary thank you for catching those edge cases!

  1. If the flow name is very long, I think there ought to be a bit of padding on the LH edge

I have added 6px of padding to the LH edge for long flow names.

Screenshot 2026-03-03 at 10 09 27 AM Screenshot 2026-03-03 at 10 09 33 AM
  1. In the case of a subflow with a long name, the icon is getting pushed off the edge of the tab

Subflow icon has been restored to the proper position.

Screenshot 2026-03-03 at 10 10 20 AM

@knolleary knolleary merged commit 0ca5abb into node-red:sidebar-redux Mar 4, 2026
1 check passed
@bonanitech bonanitech mentioned this pull request Mar 10, 2026
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@knolleary knolleary knolleary left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@n-lark @knolleary