fix: prevent incorrect array modification in delay node#5457
Merged
knolleary merged 1 commit intonode-red:masterfrom Jan 26, 2026
Merged
fix: prevent incorrect array modification in delay node#5457knolleary merged 1 commit intonode-red:masterfrom
knolleary merged 1 commit intonode-red:masterfrom
Conversation
Check indexOf result before splicing to prevent removing wrong element when clearDelayList() runs between timeout registration and execution. If indexOf returns -1 (id already removed), splice(-1, 1) would incorrectly remove the last element. Now we skip the splice if id is not found. Fixes: #3
Member
|
Thanks of the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5451 - The delay node could incorrectly remove the last element from
idListwhenindexOf()returns -1.Changes
Check indexOf result before splicing at three locations:
Test Plan