Skip to content

TreeList: Fix arrow navigation through filtered TreeList#5431

Merged
knolleary merged 1 commit intonode-red:masterfrom
piotrbogun:5430/TreeList/filtered-arrow-navigation
Mar 24, 2026
Merged

TreeList: Fix arrow navigation through filtered TreeList#5431
knolleary merged 1 commit intonode-red:masterfrom
piotrbogun:5430/TreeList/filtered-arrow-navigation

Conversation

@piotrbogun
Copy link
Copy Markdown
Contributor

@piotrbogun piotrbogun commented Jan 8, 2026

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

Resolves #5430

EditableList hides filtered items with .hide(). Added a css display check when picking the next/previous sibling/child in the TreeList component. With this change, users should be able to navigate through the visible list. Went with this approach for the initial fix as it's a small code change.

Could alternatively:

  • Make updates to have TreeList go through an actual filtered set of nodes so we don't have to do any checks like this.
  • Add some kind of isFiltered flag to the items. Would prefer the above.

Before change

tree_list_filter_pre_fix.mp4

After change

tree_list_filter_fix.mp4

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run npm run test to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@knolleary
Copy link
Copy Markdown
Member

Thank you @piotrbogun - my apologies for the delay getting this in.

@knolleary knolleary merged commit abe6593 into node-red:master Mar 24, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TreeList component allows navigating to filtered out items with arrow keys

2 participants