Add package-lock.json for reproducible dependency chains#5426
Merged
knolleary merged 1 commit intonode-red:masterfrom Jan 7, 2026
Merged
Add package-lock.json for reproducible dependency chains#5426knolleary merged 1 commit intonode-red:masterfrom
knolleary merged 1 commit intonode-red:masterfrom
Conversation
- Remove package-lock.json from .gitignore - Add validated package-lock.json (Node 20, 1003 packages) - Update CI workflow to use npm ci instead of npm install - Update README development instructions to use npm ci This ensures all developers and CI get identical dependency trees, protecting against npm supply chain attacks where compromised patch versions could automatically propagate through semver ranges. Closes node-red#5424
This was referenced Jan 7, 2026
Member
|
This will be okay for the dev environment, but the way release builds are generated (as this is a mono-repo with multiple npm packages in) will need overhauling so they each get a valid package-lock.json generated. Happy to merge this as a step one, but it won't be Job Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
package-lock.json(1003 packages, Node 20)package-lock.jsonfrom.gitignorenpm ciEnsures identical dependency trees across all environments, mitigating supply chain attack vectors.
Closes #5424