5404/Editor/Bug: Junction error in Quick Add dialog#5407
Merged
knolleary merged 1 commit intonode-red:masterfrom Jan 5, 2026
Merged
Conversation
Member
|
@piotrbogun Thank you for fixing the issue. 💯 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
Proposed changes
Resolves #5404
In the
setSuggestedFlowmethod for the quick add menu, there is a missing check for thejunctionnode type which causes the console error as well as prevents the preview item from appearing in the editor when this menu option is hovered.This view file contains similar checks for the
junctionnode type so I followed the current pattern for this fix.Checklist
npm run testto verify the unit tests pass