Editor: Flow & subflow names are changed to all lowercase in search dialog #5348#5401
Merged
knolleary merged 6 commits intonode-red:masterfrom Jan 7, 2026
Merged
Conversation
49f7496 to
af6e2c1
Compare
knolleary
reviewed
Jan 5, 2026
knolleary
requested changes
Jan 5, 2026
Member
knolleary
left a comment
There was a problem hiding this comment.
Thanks for this.
As you've noted, we don't currently have a strategy for unit testing front-end code like this. The long-standing IIFE approach doesn't lend itself too well to it - not ideal to be exposing internal functions on the api like this.
I'd prefer not to get wrapped up in identifying how to improve the UT approach at the same time as trying to deliver this specific fix. We should separate those discussions.
We can run with this PR for now (just need the old copyright header removing from the new file - something we'll be doing to all files in the near future).
…copyright Co-authored-by: Nick O'Leary <nick.oleary@gmail.com>
Contributor
Author
|
Thanks @knolleary, I’ve removed the old copyright header as suggested. |
knolleary
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixed #5348
Preserves original casing of flow/subflow names in search dialog results. The fix separates the index key (lowercase for case-insensitive searching) from the display label (original casing).
Also added:
Note: I added test exports (_indexNode, _index) to enable unit testing for this fix. I noticed the UI modules use the IIFE pattern, is there a preferred approach for making these testable? I'm curious if there's interest in exploring ES6 classes for future work, but happy to follow whatever patterns the project prefers.
Checklist
npm run testto verify the unit tests pass