Conversation
and tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and tests
Proposed changes
Adds a burst mode to the delay node as per this discussion - https://discourse.nodered.org/t/delay-node-rate-limit-strange-behaviour-confusing-limit-rates-is-it-lying-us-a-little/100005 - It has also been mentioned several times before that we don't handle bursts as the present implementation is confusing.
This PR - add a new mode - burst - (vs the old mode, evenly spaced) - this allows the number of msgs specified through then blocks - using the time period specified as a sliding time window to unlock as required... excess messages can either be dropped, or sent to the second output - they are not queued.
Checklist
npm run testto verify the unit tests pass