Fix complete node to not feedback immediately connected nodes#5114
Merged
Fix complete node to not feedback immediately connected nodes#5114
Conversation
knolleary
approved these changes
Jun 6, 2025
Member
knolleary
left a comment
There was a problem hiding this comment.
A couple comments on the code to update, but otherwise, all good.
packages/node_modules/@node-red/nodes/core/common/24-complete.js
Outdated
Show resolved
Hide resolved
knolleary
reviewed
Jun 6, 2025
knolleary
reviewed
Jun 6, 2025
packages/node_modules/@node-red/nodes/core/common/24-complete.js
Outdated
Show resolved
Hide resolved
Member
|
Letting the tests run through. If they have passed and this PR hasn't been merged yet... please merge it if you can ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This fix automatically filters out any nodes that are directly connected to the complete node that would otherwise feedback straight into the complete node... It DOES NOT filter nodes that are indirectly connected - but does fix the simple use case where someone connects a debug direct to the complete node to see what is returned but forgets to remove it from the scope of the complete node.
Checklist
npm run testto verify the unit tests pass