Conversation
So they stay alongside flows
Member
Author
|
Hi @knolleary - did this drop off the 4.1 radar ? Can we get it into 4.1.1 or whenever that "clicking outside" fix goes in please ? |
Member
Author
|
@knolleary Likewise - can we get this bumped back into the contention please. |
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
@knolleary - Hi any chance of this being merged or not ? Obvs would prefer it to be merged - but if not I need to make a permanent work around. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
If you specify the location of the flows file to be somewhere else then currently the flows_cred.json file remains located in the userdir. This PR checks to see if the file already exists in the userdir (so as not to break existing uses) - but if not - then it creates the cred file in the same directory as the flows so that copying them manually is simplified.
It also means that when using docker and setting the flows to be mounted outside the container for persistence then the creds are also persisted alongside them.
Hopefully this doesn't break existing users - but as it is a change of behaviour it may need a serious version bump.
Checklist
npm run testto verify the unit tests pass