-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Can not delete local branch at project settings when branch name contains / #5477
Copy link
Copy link
Closed
Closed
Copy link
Description
Current Behavior
Unable to delete a local branch like test/case_1 , got 404 Not Found error.
In the request url, branch param test/case_1 is not uri encoded.
Expected Behavior
Should able to delete a local branch, which name is like test/case_1
Branch param test/case_1 should be uri encoded as test%2Fcase_1
Should update follow line:
node-red/packages/node_modules/@node-red/editor-client/src/js/ui/projects/projectSettings.js
Line 1262 in 56c641f
| var url = "projects/"+activeProject.name+"/branches/"+entry.name; |
to:
var url = "projects/"+activeProject.name+"/branches/"+encodeURIComponent(entry.name); Steps To Reproduce
- create local branch
test/case_1 - checkout another branch
- go to project settings
- try delete branch
test/case_1
Example flow
no need flow
Environment
run with docker:
docker run -it -p 1880:1880 -v myNodeREDdata:/data --name mynodered nodered/node-red:4.1.3
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels