Skip to content

Can not delete local branch at project settings when branch name contains / #5477

@yue-wen

Description

@yue-wen

Current Behavior

Unable to delete a local branch like test/case_1 , got 404 Not Found error.

In the request url, branch param test/case_1 is not uri encoded.

Expected Behavior

Should able to delete a local branch, which name is like test/case_1

Branch param test/case_1 should be uri encoded as test%2Fcase_1

Should update follow line:

var url = "projects/"+activeProject.name+"/branches/"+entry.name;

to:

          var url = "projects/"+activeProject.name+"/branches/"+encodeURIComponent(entry.name); 

Steps To Reproduce

  1. create local branch test/case_1
  2. checkout another branch
  3. go to project settings
  4. try delete branch test/case_1

Example flow

no need flow

Environment

run with docker:
docker run -it -p 1880:1880 -v myNodeREDdata:/data --name mynodered nodered/node-red:4.1.3

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions