fix: apply suggested pr review changes

Julien Castelain · Ryan Garant · commit 81624e7226a1 · 2019-11-25T08:01:56.000-08:00
diff --git a/src/utils.ts b/src/utils.ts
@@ -77,14 +77,13 @@ export function openFileInEditor(fileName: string, msg: string): string {
 
         writeFileSync(filePath, msg)
 
-        const editor = process.env.EDITOR
-            ? process.env.EDITOR
-            : process.env.VISUAL
-            ? process.env.VISUAL
-            : spawnSync('git', ['config', '--global', 'core.editor']).stdout
+        const editor =
+            process.env.EDITOR ||
+            process.env.VISUAL ||
+            spawnSync('git', ['config', '--global', 'core.editor']).stdout
 
         if (!editor) {
-            throw new Error('Could not determine which editor to use')
+            return 'Could not determine which editor to use'
         }
 
         execSyncInteractiveStream(`${editor} "${filePath}"`)
