fix: make opts.filename from #591 work with opts.keepExtensions #597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charlike Mike Reagent <opensource@tunnckocore.com>
|
Thank you for raising your pull request. Please make sure again that you have followed our contributing guidelines and the code of conduct. We will review it as soon as possible. |
Codecov Report
@@ Coverage Diff @@
## master #597 +/- ##
==========================================
- Coverage 83.93% 82.81% -1.12%
==========================================
Files 14 14
Lines 635 646 +11
Branches 104 107 +3
==========================================
+ Hits 533 535 +2
- Misses 93 101 +8
- Partials 9 10 +1
Continue to review full report at Codecov.
|
Signed-off-by: Charlike Mike Reagent <opensource@tunnckocore.com>
Signed-off-by: Charlike Mike Reagent <opensource@tunnckocore.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
options.filenamefrom feat: custom file (re)naming, sanitizing - use the newoptions.filename#591 work whenoptions.keepExtensions: true.keepExtensionswork properly when multiple file extensions, like.tar.gz