Adjust filename regex to allow filenames with semicolons #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hi, I won't be able to merge this right away as this breaks an existing test showing an upload issue with quotes in filenames in IE. I'll look for a proper solution in the parser. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This little change tweaks the filename-matching regex to allow for filenames with semicolons. Currently the presence of a semicolon in the file name makes the filename regex not match, so part.filename doesn't get set, which makes the test in incoming_form line 147 return false, so it applies the maxFieldsSize check. I noticed this because my server was throwing an error when trying to upload a large podcast file.
Thanks for the nice library, it's been very helpful for my app Listening Room (http://listeningroom.net).