Skip to content

Conversation

@tunnckoCore
Copy link
Member

while form upload file, if not select file, still create an empty temporary file!

from #374

while form upload file, if not select file, still create an empty temporary file!
@tunnckoCore
Copy link
Member Author

tunnckoCore commented Nov 28, 2019

Okay, this seems to fail, tests never end - I canceled them. Not sure if we need to replace the undefined case or it should be that way.

@tunnckoCore
Copy link
Member Author

tunnckoCore commented Jan 29, 2020

Oh yea. I was wondering today which issue/pr was that and what was it about ;d

Linking #545 and #415 to have it more near to my stuff.

Also, it probably is fixed too, because it checks against !part.mime to detect whether it's a file or field.

We should add some option to control it through option

@tunnckoCore tunnckoCore deleted the empty-temp-file-fix branch January 29, 2020 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants