Conversation
added 2 commits
May 24, 2020 00:20
Member
|
Our Coveralls Coverage decreased by |
Member
Author
|
@NotMoni This was due to instanbul ignore comments not being replaced with c8 ignore comments (we apparently did not change them). Now the coverage is much better ;) |
Member
|
@xxczaki Oh, Alright Mate. 👍 |
NotMoni
approved these changes
May 24, 2020
added 2 commits
May 24, 2020 15:15
Member
Author
|
This should be merged after #834. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
This PR removes some of the ignored xo linter rules so that the code is more readable.
What changes did you make? (provide an overview)
Removed ignored linter rules and linted the files (including docs).
Which issue (if any) does this pull request address?
N/A
Is there anything you'd like reviewers to know?
This PR might look rather large. However, most of the changes are actually small.