check for global.fetch before binding it#674
Merged
Richienb merged 1 commit intonode-fetch:masterfrom Sep 16, 2019
Merged
Conversation
Collaborator
|
AFAIK we will be dropping The correct solution would be to use some of these suggested modules that export correctly given contexts. https://github.com/bitinn/node-fetch#motivation Otherwise LGTM |
This was referenced Sep 12, 2020
This was referenced Mar 6, 2021
Closed
This was referenced Mar 17, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We ran into some issues where this was executed in browsers that didn't support fetch (e.g. IE11)