Skip to content

test: Update major busboy version#1457

Merged
jimmywarting merged 2 commits intonode-fetch:mainfrom
jimmywarting:bump-busboy
Jan 17, 2022
Merged

test: Update major busboy version#1457
jimmywarting merged 2 commits intonode-fetch:mainfrom
jimmywarting:bump-busboy

Conversation

@jimmywarting
Copy link
Collaborator

@jimmywarting jimmywarting commented Jan 16, 2022 •
edited
Loading

Purpose

dependabot wasn't able to update busboy cuz it had breaking changes...

Changes

Only affect the test server...

Additional information

I was thinking maybe we don't really need the busboy...? we could just simply echo everything back and utilize node-fetch new body.formData() parsers.
and then do something like:

fetch('/multipart', { method: 'post', body: formData })
  .then(res => res.formData())
  .then(formData => {
    // expect responded formData to match the posted formData
  })

Dos removing the dependency on busboy...

  • Decide if we want to keep busboy as a dependency... if not:
    • use res.formData() to decode it.

@jimmywarting jimmywarting added this to the Version 3.x.x milestone Jan 16, 2022
@jimmywarting jimmywarting changed the title test: Update busboy test: Update major busboy version Jan 16, 2022
LinusU
LinusU approved these changes Jan 17, 2022
View reviewed changes
Copy link
Member

@LinusU LinusU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat 👍

@jimmywarting jimmywarting merged commit 1028f83 into node-fetch:main Jan 17, 2022
@jimmywarting jimmywarting deleted the bump-busboy branch January 17, 2022 15:37
@github-actions
Copy link

github-actions bot commented Jan 20, 2022

🎉 This PR is included in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gr2m gr2m gr2m approved these changes

@LinusU LinusU LinusU approved these changes

@bitinn bitinn Awaiting requested review from bitinn

@Richienb Richienb Awaiting requested review from Richienb

@tekwiz tekwiz Awaiting requested review from tekwiz

Assignees

No one assigned

Labels

released v3

Projects

None yet

Milestone

Version 3.x.x

Development

Successfully merging this pull request may close these issues.

3 participants

@jimmywarting @gr2m @LinusU