2.x: Specify encoding as an optional peer dependency in package.json#1310
Merged
jimmywarting merged 2 commits intonode-fetch:2.xfrom Nov 5, 2021
Merged
2.x: Specify encoding as an optional peer dependency in package.json#1310jimmywarting merged 2 commits intonode-fetch:2.xfrom
jimmywarting merged 2 commits intonode-fetch:2.xfrom
Conversation
LinusU
reviewed
Nov 5, 2021
Co-authored-by: Linus Unnebäck <linus@folkdatorn.se>
jimmywarting
approved these changes
Nov 5, 2021
This was referenced Jan 31, 2022
This was referenced Jun 25, 2022
|
🎉 This PR is included in version 2.6.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Heads up that this was actually a breaking change within v2 - it being optional doesn't change that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
What changes did you make? (provide an overview)
I installed node-fetch 2.x on my project with Yarn 2 (aka Yarn berry). When I call
require('node-fetch'), I get this warning message:It seems that
encodingpackage is optional and only used inbody.textConverted()method (discussed in #412).So I added the following to
package.jsonof node-fetch:Which issue (if any) does this pull request address?
Is there anything you'd like reviewers to know?