fix: import whatwg-url in a way compatible with ESM Node#1303
fix: import whatwg-url in a way compatible with ESM Node#1303jimmywarting merged 2 commits into2.xfrom
Conversation
14e1f39 to
51627fe
Compare
51627fe to
a3d8a98
Compare
|
Any possible way to unit test this also? |
I haven't found one yet, since I cannot trigger the issue myself (even though I think that you shouldn't be able to import it like that 😄) Waiting for more information from @robrecord
Will fix ✅ |
|
Thank you, I will review ASAP. |
|
I have confirmed this fixes the error I was facing. Thank you! |
|
This should fix #1305 |
|
@robrecord or @paranoidjk do you know of any easy way we could add a test for this? |
|
@jimmywarting I've added changelog entry and bumped the package version. What do you think of merging this without a test for now, and adding one later as this seems to be breaking some peoples workflow and they have to pin node-fetch at a lower version currently? |
|
Yea, can release it without a test |
|
If I can find an easy way to have this tested I will add it here. |
Great |
What is the purpose of this pull request?
What changes did you make? (provide an overview)
I imported
whatwg-urlin a way that is compatible with Node.js running in ESM mode.Which issue (if any) does this pull request address?
ace7536#r56836783
Is there anything you'd like reviewers to know?
n/a
closes #1305