Codecov Report

Merging #1274 (d9a4a07) into 2.x (b5e2e41) will decrease coverage by 0.34%.
The diff coverage is n/a.

❗ Current head d9a4a07 differs from pull request most recent head dd73fe7. Consider uploading reports for the commit dd73fe7 to get more accurate results

@@             Coverage Diff             @@
##               2.x    #1274      +/-   ##
===========================================
- Coverage   100.00%   99.65%   -0.35%     
===========================================
  Files            7        7              
  Lines          573      573              
  Branches       183      183              
===========================================
- Hits           573      571       -2     
- Misses           0        1       +1     
- Partials         0        1       +1     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5e2e41...dd73fe7. Read the comment docs.

Seems like teeny-request has a breaking change for an older node version where it uses spread ... would it help to install it as a dep, pin it so codecov uses it instead?

Ironically codecov uses teeny-request
and teeny-request just wraps node-fetch v2.6.1

So we use our own fetch api to test our own api...

but at codecov i found out that:

On February 1, 2022 this uploader will be completely deprecated and will no longer be able to upload coverage to Codecov.
https://github.com/codecov/codecov-node/blob/master/README.md

... do rollup have some breaking change also?

src/index.js → lib/index.js, lib/index.es.js, lib/index.mjs...
[!] TypeError: Cannot read property 'src' of undefined
TypeError: Cannot read property 'src' of undefined
    at external (./node-fetch/rollup.config.js:47:52)

the external function did something that didn't work. 2b0610d
don't remember what we use this for...
either way... we don't have any dependencies in package.json so i just removed that part and it started working again.