Skip to content

V3 stable release#1257

Merged
jimmywarting merged 2 commits intonode-fetch:mainfrom
jimmywarting:v3-stable
Aug 31, 2021
Merged

V3 stable release#1257
jimmywarting merged 2 commits intonode-fetch:mainfrom
jimmywarting:v3-stable

Conversation

@jimmywarting
Copy link
Copy Markdown
Collaborator

@jimmywarting jimmywarting commented Aug 28, 2021 •
edited
Loading

Purpose

Going out of beta and marking v3 as stable

Changes

package.json version + changelog only

Additional information

Have kind of forgot what the procedure is to release something on github/npm
is there some auto release to npm when a github tag is generated or something?

@jimmywarting jimmywarting added this to the Version 3.0.0 milestone Aug 28, 2021
@jimmywarting jimmywarting changed the title V3 stable V3 stable release Aug 28, 2021
@Richienb
Copy link
Copy Markdown
Member

Richienb commented Aug 28, 2021

Have kind of forgot what the procedure is to release something on github/npm

Since we aren't bundling anything anymore, np will come in handy.

@jimmywarting
Copy link
Copy Markdown
Collaborator Author

jimmywarting commented Aug 28, 2021 •
edited
Loading

Since we aren't bundling anything anymore, np will come in handy.

np was quite large: https://npmgraph.js.org/?q=np
354 Modules!

Would kind of rather have some github workflow automations instead

It's easy to tag a new github version without having to make a PR like this one and having to wait for other members to review & accept it.

@gr2m
Copy link
Copy Markdown
Collaborator

gr2m commented Aug 28, 2021

I can setup semantic-release. I think I suggested it before? I’m a co maintainer of @semantic-release so I can take ownership of that part

@jimmywarting
Copy link
Copy Markdown
Collaborator Author

jimmywarting commented Aug 28, 2021 •
edited
Loading

I can setup semantic-release. I think I suggested it before? I’m a co maintainer of @semantic-release so I can take ownership of that part

Think that would be grate to have! I say go for it

@gr2m gr2m assigned gr2m and unassigned gr2m Aug 29, 2021
@gr2m
Copy link
Copy Markdown
Collaborator

gr2m commented Aug 29, 2021 •
edited
Loading

I can setup semantic-release. I think I suggested it before? I’m a co maintainer of @semantic-release so I can take ownership of that part

Think that would be grate to have! I say go for it

Unless there are any objections, we can go ahead and merge this PR, then I can do the semantic-release setup in its own PR

@node-fetch node-fetch deleted a comment from Richienb Aug 31, 2021
@jimmywarting jimmywarting merged commit 2603c67 into node-fetch:main Aug 31, 2021
@jimmywarting jimmywarting deleted the v3-stable branch August 31, 2021 15:54
@gr2m
Copy link
Copy Markdown
Collaborator

gr2m commented Aug 31, 2021

I can work on the semantic-release setup PR on Thursday.

@gr2m gr2m mentioned this pull request Sep 3, 2021
Merged
8 tasks
@Pencab

This comment has been minimized.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gr2m gr2m gr2m approved these changes

@tinovyatkin tinovyatkin tinovyatkin approved these changes

@bitinn bitinn Awaiting requested review from bitinn

@LinusU LinusU Awaiting requested review from LinusU

@Richienb Richienb Awaiting requested review from Richienb

@tekwiz tekwiz Awaiting requested review from tekwiz

@TimothyGu TimothyGu Awaiting requested review from TimothyGu

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

v3 Roadmap

5 participants

@jimmywarting @Richienb @gr2m @Pencab @tinovyatkin