Remove files from configSources that are not part of the config sources.#821
Merged
jdmarshall merged 1 commit intonode-config:masterfrom Jul 15, 2025
Merged
Conversation
Collaborator
Author
|
Coverage % drops slightly because this removed covered code from a file that has some uncovered functions in it. Probably should fix that in 4.0.x |
markstos
approved these changes
Jun 16, 2025
parseFile adding any calls to the configSources causes the union of the configSources to not match Config.get() fixes node-config#806
d9c7a72 to
31dde2b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parseFile adding any calls to the configSources causes the union of the configSources to not match Config.get()
fixes #806
I don't want to merge this for a big yet, to give time for any other 4.0 issues to be sorted before we start merging more breaking changes. But I wanted to clear this off of my mental todo list.