Skip to content

Modify convert_bin_from_pgn-extract#88

Merged
nodchip merged 2 commits intonodchip:masterfrom
tttak:convert_bin_from_pgn-extract_20200819
Aug 21, 2020
Merged

Modify convert_bin_from_pgn-extract#88
nodchip merged 2 commits intonodchip:masterfrom
tttak:convert_bin_from_pgn-extract_20200819

Conversation

@tttak
Copy link

@tttak tttak commented Aug 21, 2020

I modified convert_bin_from_pgn-extract based on requests from linox and yorkman in discord.

learn convert_bin_from_pgn-extract pgn_eval_side_to_move 1 convert_no_eval_fens_as_score_zero 1 output_file_name out.bin in.txt

The modified convert_bin_from_pgn-extract now supports the following forms of eval

  • { [%eval 0.25] [%clk 0:10:00] }
  • { +0.71/22 1.2s }
  • { 0.60 }
  • { book }
  • no eval
  • others

I added the option "convert_no_eval_fens_as_score_zero".
In the case of the above { book }, no eval, others

  • convert_no_eval_fens_as_score_zero 0 : Skip the conversion of the fen.
  • convert_no_eval_fens_as_score_zero 1 : Convert the fen as score 0.

"convert_no_eval_fens_as_score_zero 1" allows you to convert pgn including no eval.

When the presence or absence of eval is mixed in in.txt, stockfish.exe would sometimes crash in previous versions.
The modified version does not crash, but continues processing according to the value of convert_no_eval_fens_as_score_zero.

linox helped with the testing.

@nodchip nodchip merged commit 17d2b5b into nodchip:master Aug 21, 2020
@nodchip
Copy link
Owner

nodchip commented Aug 21, 2020

Thank you for the pull request. I merged it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants