Modify convert_bin_from_pgn-extract#88
Merged
nodchip merged 2 commits intonodchip:masterfrom Aug 21, 2020
Merged
Conversation
Owner
|
Thank you for the pull request. I merged it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I modified convert_bin_from_pgn-extract based on requests from linox and yorkman in discord.
The modified convert_bin_from_pgn-extract now supports the following forms of eval
I added the option "convert_no_eval_fens_as_score_zero".
In the case of the above { book }, no eval, others
"convert_no_eval_fens_as_score_zero 1" allows you to convert pgn including no eval.
When the presence or absence of eval is mixed in in.txt, stockfish.exe would sometimes crash in previous versions.
The modified version does not crash, but continues processing according to the value of convert_no_eval_fens_as_score_zero.
linox helped with the testing.