Skip to content

Fix #490#955

Merged
paulmelnikow merged 2 commits intonock:masterfrom
petersolopov:master
Oct 20, 2017
Merged

Fix #490#955
paulmelnikow merged 2 commits intonock:masterfrom
petersolopov:master

Conversation

@petersolopov
Copy link
Copy Markdown
Member

@petersolopov petersolopov commented Aug 17, 2017 •
edited by gr2m
Loading

fixes #490

@coveralls
Copy link
Copy Markdown

coveralls commented Aug 17, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.005%) to 92.659% when pulling 690921e on n30n0v:master into 8da9ee0 on node-nock:master.

@paulmelnikow
Copy link
Copy Markdown
Member

paulmelnikow commented Sep 22, 2017

It would be good to include a test with this fix.

paulmelnikow
paulmelnikow requested changes Sep 24, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@paulmelnikow paulmelnikow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment.

@petersolopov
Copy link
Copy Markdown
Member Author

petersolopov commented Sep 25, 2017

done

@paulmelnikow
Copy link
Copy Markdown
Member

paulmelnikow commented Sep 26, 2017

Thanks! 💯

The test caused a merge conflict with master. To fix it, could you merge master into this branch?

@petersolopov
Copy link
Copy Markdown
Member Author

petersolopov commented Sep 26, 2017

yep, I've resolved conflict

@nock nock deleted a comment from coveralls Sep 26, 2017
@nock nock deleted a comment from coveralls Sep 26, 2017
@paulmelnikow paulmelnikow merged commit 4772df5 into nock:master Oct 20, 2017
@paulmelnikow
Copy link
Copy Markdown
Member

paulmelnikow commented Oct 20, 2017

Thanks!

@gr2m gr2m mentioned this pull request Oct 23, 2017
Closed
@gr2m
Copy link
Copy Markdown
Member

gr2m commented Oct 23, 2017

@n30n0v could you help us out fixing a regression from your PR? See #1003

@lock
Copy link
Copy Markdown

lock bot commented Sep 13, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you!

@lock lock bot locked as resolved and limited conversation to collaborators Sep 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@gr2m gr2m gr2m approved these changes

@paulmelnikow paulmelnikow paulmelnikow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@petersolopov @coveralls @paulmelnikow @gr2m