Update PendingMocks when an interceptor is removed#721
Merged
Conversation
Contributor
|
Code looks good. Thanks for the contribution! |
Contributor
|
Published as part of v8.2.0 🎉 |
|
Seems like I'm still seeing this as of v9.0.6. console.log('pending mocks 1', nock.pendingMocks());
console.log('removing mock');
nock.removeInterceptor(this.nock);
console.log('pending mocks 2', nock.pendingMocks());The second dump of UpdateMy mistake. I was storing the result of |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when you call
nock.removeInterceptor(interceptor)it stops that interceptor from doing any more intercepting, but doesn't remove it frompendingMocks()(this is part of #600).This fixes that, by updating the interceptor's scope to remove it properly. I.e. with this change, pendingMocks is now empty at the end, as expected:
It looks like there's a separate issue in #600 that I haven't looked at about how
nock.pendingMocks()behaves with scope reuse. This patch doesn't fix that (and I'm probably not going to, since it doesn't affect me).This patch also includes an unrelated change to remove replyWithFile from browserify-bundle. Not really sure why, but I'd guess this means somebody else made that change in lib/ recently and forgot to commit the corresponding browserify-bundle.