Conversation
|
🎉 This PR is included in version 14.0.12 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2893.
When a query string contains params like
parent=value&parent.1=first, theexpand()function incommon.jswould crash withCannot assign to read only property '1' of string 'value'. This happened becauseexpand()first setparentto the string'value', then tried to traverse into it as an object when processing theparent.1key.The fix adds a check before descending into an intermediate path segment: if the existing value is a non-null primitive (not an object or array), return
undefined— the same sentinel value already used when a blocklisted key is encountered.dataEqualthen compares both sides asundefined, which causes them to match correctly when both the intercepted URL and the nock scope have the same unbalanced query params.