docs(CONTRIBUTING): Remove traces of airplane mode by paulmelnikow · Pull Request #1367 · nock/nock

paulmelnikow · 2019-01-06T15:13:41Z

This comment doesn't make sense to me and I'm not clear what needs to happen with this code:

Lines 59 to 94 in 26954a7

    
           // this is a temporary as we get rid of all the {skip: process.env.AIRPLANE} 
        
           // settings. When we are done with all, replace nockBackWithFixture and get 
        
           // rid of this function and the goodRequestLocalhost.json fixtures 
        
           function nockBackWithFixtureLocalhost(t, scopesLoaded) { 
        
             const scopesLength = scopesLoaded ? 1 : 0 
        
             nockBack('goodRequestLocalhost.json', function(done) { 
        
               t.equal(this.scopes.length, scopesLength) 
        
               const server = http.createServer((request, response) => { 
        
                 t.pass('server received a request') 
        
                 response.writeHead(200) 
        
                 response.end() 
        
               }) 
        
               server.listen(() => { 
        
                 const request = http.request( 
        
                   { 
        
                     host: 'localhost', 
        
                     path: '/', 
        
                     port: server.address().port, 
        
                   }, 
        
                   response => { 
        
                     t.is(200, response.statusCode) 
        
                     this.assertScopesFinished() 
        
                     done() 
        
                     server.close(t.end) 
        
                   } 
        
                 ) 
        
                 request.on('error', t.error) 
        
                 request.end() 
        
               }) 
        
             }) 
        
           }

Close #1077.

gr2m

This looks good, but please hold off merging just yet, I want us to celebrate this :) Not sure how yet but will think of something. Great work 👏👏👏

paulmelnikow · 2019-01-06T18:38:34Z

Any clarity on what to do with the bits in test_back.js?

gr2m · 2019-01-06T18:44:00Z

Any clarity on what to do with the bits in test_back.js?

Honestly, no idea! It’s been 10 months since I added this comment, I’d have to understand it myself. I gotta focus on other work until Wednesday unfortunately.

paulmelnikow · 2019-01-06T18:51:50Z

Okay. If it's time to merge this and we can't figure it out we can edit the comment.

lihail · 2019-01-07T06:13:25Z

If I got this right, you should remove this function (and goodRequestLocalhost.json, but for some reason I can't find it..), and replace every occurrence of this function with a call to nockBackWithFixture instead

paulmelnikow · 2019-01-14T18:06:57Z

It'd be great to get this merged before Friday! Shall I leave the test code intact and edit the comment so it no longer mentions AIRPLANE?

nock/tests/test_back.js

Lines 59 to 94 in 26954a7

    
           // this is a temporary as we get rid of all the {skip: process.env.AIRPLANE} 
        
           // settings. When we are done with all, replace nockBackWithFixture and get 
        
           // rid of this function and the goodRequestLocalhost.json fixtures 
        
           function nockBackWithFixtureLocalhost(t, scopesLoaded) { 
        
             const scopesLength = scopesLoaded ? 1 : 0 
        
             nockBack('goodRequestLocalhost.json', function(done) { 
        
               t.equal(this.scopes.length, scopesLength) 
        
               const server = http.createServer((request, response) => { 
        
                 t.pass('server received a request') 
        
                 response.writeHead(200) 
        
                 response.end() 
        
               }) 
        
               server.listen(() => { 
        
                 const request = http.request( 
        
                   { 
        
                     host: 'localhost', 
        
                     path: '/', 
        
                     port: server.address().port, 
        
                   }, 
        
                   response => { 
        
                     t.is(200, response.statusCode) 
        
                     this.assertScopesFinished() 
        
                     done() 
        
                     server.close(t.end) 
        
                   } 
        
                 ) 
        
                 request.on('error', t.error) 
        
                 request.end() 
        
               }) 
        
             }) 
        
           }

gr2m · 2019-01-14T18:16:45Z

We can merge now, @RichardLitt will post the announcement for the Hackathon today.

Yeah, let's remove all code and comments that still reference "process.env.AIRPLANE" 🎉

RichardLitt · 2019-01-16T18:13:04Z

Announced! See #1268. :)

nockbot · 2019-01-19T03:12:49Z

🎉 This PR is included in version 11.0.0-beta.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

nockbot · 2019-08-13T00:03:01Z

🎉 This PR is included in version 11.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

docs(CONTRIBUTING): Remove traces of airplane mode

d8ddafb

Close #1077.

jlilja approved these changes Jan 6, 2019

View reviewed changes

gr2m mentioned this pull request Jan 6, 2019

Nock-1077 Remove airplane mode #1209

Merged

gr2m reviewed Jan 6, 2019

View reviewed changes

lihail approved these changes Jan 7, 2019

View reviewed changes

gr2m merged commit 3fa7280 into beta Jan 16, 2019

gr2m deleted the bye-airplane branch January 16, 2019 15:51

nockbot added the released on @beta label Jan 19, 2019

weekly-digest bot mentioned this pull request Jan 20, 2019

Weekly Digest (13 January, 2019 - 20 January, 2019) #1388

Closed

nockbot added the released label Aug 13, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

docs(CONTRIBUTING): Remove traces of airplane mode#1367

docs(CONTRIBUTING): Remove traces of airplane mode#1367
gr2m merged 1 commit intobetafrom
bye-airplane

paulmelnikow commented Jan 6, 2019

Uh oh!

gr2m left a comment

Uh oh!

paulmelnikow commented Jan 6, 2019

Uh oh!

gr2m commented Jan 6, 2019

Uh oh!

paulmelnikow commented Jan 6, 2019

Uh oh!

lihail commented Jan 7, 2019

Uh oh!

paulmelnikow commented Jan 14, 2019

Uh oh!

gr2m commented Jan 14, 2019

Uh oh!

RichardLitt commented Jan 16, 2019

Uh oh!

nockbot commented Jan 19, 2019

Uh oh!

nockbot commented Aug 13, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

	// this is a temporary as we get rid of all the {skip: process.env.AIRPLANE}
	// settings. When we are done with all, replace nockBackWithFixture and get
	// rid of this function and the goodRequestLocalhost.json fixtures
	function nockBackWithFixtureLocalhost(t, scopesLoaded) {
	const scopesLength = scopesLoaded ? 1 : 0

	nockBack('goodRequestLocalhost.json', function(done) {
	t.equal(this.scopes.length, scopesLength)

	const server = http.createServer((request, response) => {
	t.pass('server received a request')

	response.writeHead(200)
	response.end()
	})

	server.listen(() => {
	const request = http.request(
	{
	host: 'localhost',
	path: '/',
	port: server.address().port,
	},
	response => {
	t.is(200, response.statusCode)
	this.assertScopesFinished()
	done()
	server.close(t.end)
	}
	)

	request.on('error', t.error)
	request.end()
	})
	})
	}

Uh oh!

Conversation

paulmelnikow commented Jan 6, 2019

Uh oh!

gr2m left a comment

Choose a reason for hiding this comment

Uh oh!

paulmelnikow commented Jan 6, 2019

Uh oh!

gr2m commented Jan 6, 2019

Uh oh!

paulmelnikow commented Jan 6, 2019

Uh oh!

lihail commented Jan 7, 2019

Uh oh!

paulmelnikow commented Jan 14, 2019

Uh oh!

gr2m commented Jan 14, 2019

Uh oh!

RichardLitt commented Jan 16, 2019

Uh oh!

nockbot commented Jan 19, 2019

Uh oh!

nockbot commented Aug 13, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants