test(test_recorder): De-airplane remaining recorder tests#1283
Conversation
| }); | ||
|
|
||
| // Do not copy tests that rely on the process.env.AIRPLANE, we are deprecating that via #1231 | ||
| test('records and replays gzipped nocks correctly when gzip is returned as a string', {skip: process.env.AIRPLANE}, function(t) { |
There was a problem hiding this comment.
It's not clear how this test is supposed to be different from the one before it. Absent a reason to keep it, I removed it.
gr2m
left a comment
There was a problem hiding this comment.
OMG nearly there 🚀 Thanks Paul!!!
|
I don’t mind the reduction in coverage, but don’t want to merge in case you are still looking into it. I’ll leave the merge up to you :) |
|
Huh. Do you see a place where the lost coverage appears? I'm looking at https://coveralls.io/builds/20663567 but that's only showing increases. |
|
I only managed to re-enable coverals, might be a glitch, let’s ignore it :) |
|
🎉 This PR is included in version 11.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 10.0.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you! |
|
🎉 This PR is included in version 11.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Ref #1077