Skip to content

handle statusCode without payload with array notation, fix script for…#1203

Merged
gr2m merged 2 commits intonock:masterfrom
StarpTech:feature/#1170_handle_statusCode_when_body_is_empty
Sep 9, 2018
Merged

handle statusCode without payload with array notation, fix script for…#1203
gr2m merged 2 commits intonock:masterfrom
StarpTech:feature/#1170_handle_statusCode_when_body_is_empty

Conversation

@StarpTech
Copy link
Copy Markdown
Contributor

Fix #1170

@RichardLitt
Copy link
Copy Markdown
Member

Well, this looks great to me. Thanks, @StarpTech!

Any other maintainers: look good?

@gr2m gr2m merged commit 21c255f into nock:master Sep 9, 2018
@gr2m
Copy link
Copy Markdown
Member

gr2m commented Sep 9, 2018

thanks 💐

@gr2m
Copy link
Copy Markdown
Member

gr2m commented Sep 12, 2018

Hey @StarpTech I don’t understand what happened, but the new test you added is failing now. For example see https://travis-ci.org/nock/nock/jobs/427482547#L3903

I did rm -rf node_modules && npm install && ./node_modules/.bin/tap ./tests/test_intercept.js and was able to reproduce the problem locally. Could have look if you can reproduce it yourself?

This is super odd because the CI passed on your PR ¯\_(ツ)_/¯

@nockbot
Copy link
Copy Markdown
Collaborator

nockbot commented Sep 14, 2018

🎉 This PR is included in version 10.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lock
Copy link
Copy Markdown

lock bot commented Sep 28, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you!

@lock lock bot locked as resolved and limited conversation to collaborators Sep 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants