Conversation
|
ugh I don’t know why tests fail with Node 10 :( If anyone could help to look into it, that’d be great 🙏 |
|
If anyone wants to look into it, it seems to be a problem limited to Update: should be good now #1148 |
703c62a to
d03dc34
Compare
|
I’ll hold off with the major release, there are a few other things I’d like to release as part of v10 |
|
What is the status on removing Node 4? Is there something still needed to be fixed before the merge? On a sidenote - Once Node 4 is dropped I'd like to do some refactoring. Would something like that need its own issue or would you just recommend a pr with points on why and how the refactor was made? |
|
I think I was holding off to see if there are other breaking changes that we can ship with it. Before doing refactoring, I’d like to finish up the tests first.
Only when we are confident with our test we can start refactoring, otherwise I’d be really afraid to break peoples code, given how widely used nock is right now. I know fixing the tests on such an old code base is no fun ... do you think you can help out with that? |
d03dc34 to
51275a7
Compare
BREAKING CHANGE: drop official support for Node 4. There is no intentional change that breaks usage in Node 4, but as we stop testing in this no longer supported Node version we recommend to no update nock if you still rely on Node 4. The reason why we decided to go ahead and make a breaking version release is that it became increasingly harder to update dependencies to the latest versions as they also drop support for Node 4.
51275a7 to
900b85b
Compare
BREAKING CHANGE: drop official support for Node < 6
|
I'll merge and release a new breaking version as discussed at #1202 |
|
🎉 This PR is included in version 10.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
\o/ Thanks, @gr2m! |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you! |
Node 4 is no longer maintained since April 1, 2018:
https://github.com/nodejs/Release#end-of-life-releases