[WIP] Remove airplane dependency from "test_intercept.js"#1104
Conversation
|
Hey @gr2m , |
tests/test_intercept.js
Outdated
| .get('/abc') | ||
| .reply(301, 'served from our mock') | ||
| .get('/wont/get/here') | ||
| .reply(301, 'served from our mock') |
There was a problem hiding this comment.
why a 301 response instead of a 200? If you do a 301 you have to set the location header: https://en.wikipedia.org/wiki/HTTP_301
There was a problem hiding this comment.
Oh, I intend to use 304 🙂
It was to differentiate b/w requests which pass through and the ones which match an interceptor
|
It’s quite long, but we can refactor later, one after the other :) |
|
I felt so too, but I wanted to keep changes focused and unit in nature, so just removing AIRPLANE dependency for now! |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you! |
Fixes #1103 . Part of #1077