test: remove airplace dependency from tests/test_back.js#313#1093
test: remove airplace dependency from tests/test_back.js#313#1093gr2m merged 1 commit intonock:masterfrom anshumanv:1092
Conversation
tests/test_back.js
Outdated
|
|
||
| request.on('error', t.error) | ||
| request.end() | ||
| }) |
There was a problem hiding this comment.
you are mixing up two spaces / four spaces indentation, which make is a bit hard to read, could you fix that please?
It looks like you forgot to close one of the brackets, see https://travis-ci.org/node-nock/nock/jobs/350166318#L1962
Make sure to run npm test locally and have it green before creating the pull request :)
There was a problem hiding this comment.
Ah, really sorry for this, my bad. Fixing :)
Perhaps I don't think the repo has a .editorconfig file, should we have one? @gr2m
There was a problem hiding this comment.
no please don’t, not everyone is using these. But you can add one to your home directory if you have a preferred style.
Usually Editors can refer the indentation style from the current file without additional configuration
|
there are still some tests failing: https://travis-ci.org/node-nock/nock/jobs/350668754 could you have a look at that? |
|
Hey @anshumanv let us know if you need help :) |
|
Ah, I'lll fix this today. 👍 |
|
I need help @gr2m, sorry for delaying this so much. 😅 |
|
@gr2m please review again. 😄 |
|
🎉 This PR is included in version 9.2.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you! |
Fixes #1092 Ref #1077
I'm really not good with tests 😅, please review carefully.
@gr2m