Remove airplane dependency from "tests/test_back.js#L261"#1090
Merged
Conversation
gr2m
reviewed
Mar 5, 2018
tests/test_back.js
Outdated
| @@ -322,23 +322,44 @@ tap.test('nockBack record tests', function (nw) { | |||
| //Adding this test because there was an issue when not calling | |||
| //nock.activate() after calling nock.restore() | |||
| nw.test('it can record twice', {skip: process.env.AIRPLANE}, function (t) { | |||
Member
There was a problem hiding this comment.
can you remove the {skip: process.env.AIRPLANE}, too?
gr2m
reviewed
Mar 5, 2018
tests/test_back.js
Outdated
| //Adding this test because there was an issue when not calling | ||
| //nock.activate() after calling nock.restore() | ||
| nw.test('it can record twice', {skip: process.env.AIRPLANE}, function (t) { | ||
|
|
Member
There was a problem hiding this comment.
nit: remove the empty line on top of a function
Contributor
Author
There was a problem hiding this comment.
I added it deliberately. Found it to improve readability for me. I'll remove it.
Member
There was a problem hiding this comment.
I might just be too used to the standard style :) thanks
42 tasks
Collaborator
|
🎉 This PR is included in version 9.2.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1086 . Part of #1077