Skip to content

test: remove airplane dependency for "tests/test_back#L137" #1083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gr2m merged 1 commit into from
Mar 2, 2018
Merged

test: remove airplane dependency for "tests/test_back#L137" #1083

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 36 additions & 2 deletions tests/test_back.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,40 @@ function nockBackWithFixture (t, scopesLoaded) {
});
}

// this is a temporary as we get rid of all the {skip: process.env.AIRPLANE}
// settings. When we are done with all, replace nockBackWithFixture and get
// rid of this function and the goodRequestLocalhost.json fixtures
function nockBackWithFixtureLocalhost (t, scopesLoaded) {
const scopesLength = scopesLoaded ? 1 : 0;

nockBack('goodRequestLocalhost.json', function (done) {
t.equals(this.scopes.length, scopesLength);

const server = http.createServer((request, response) => {
t.pass('server received a request');

response.writeHead(200);
response.end();
});

server.listen(() => {
const request = http.request({
host: 'localhost',
path: '/',
port: server.address().port
}, response => {
t.is(200, response.statusCode);
this.assertScopesFinished();
done();
server.close(t.end);
});

request.on('error', t.error);
request.end();
});
});
}

function setOriginalModeOnEnd(t, nockBack) {
t.once('end', function() {
nockBack.setMode(originalMode);
Expand Down Expand Up @@ -134,8 +168,8 @@ tap.test('nockBack wild tests', function (nw) {
testNock(t);
});

nw.test('nock back doesn\'t do anything', {skip: process.env.AIRPLANE}, function (t) {
nockBackWithFixture(t, false);
nw.test('nock back doesn\'t do anything', function (t) {
nockBackWithFixtureLocalhost(t, false);
});

setOriginalModeOnEnd(nw, nockBack);
Expand Down