Skip to content

Require Node 10+#1895

Merged
paulmelnikow merged 4 commits intobetafrom
bump-node
Feb 11, 2020
Merged

Require Node 10+#1895
paulmelnikow merged 4 commits intobetafrom
bump-node

Conversation

@paulmelnikow
Copy link
Copy Markdown
Member

@paulmelnikow paulmelnikow commented Feb 11, 2020 •
edited
Loading

BREAKING CHANGE

Close #1871

@paulmelnikow
Require Node 10+
d45bb6e 
BREAKING CHANGE
@paulmelnikow paulmelnikow added this to the 12.x milestone Feb 11, 2020
@paulmelnikow
Copy link
Copy Markdown
Member Author

paulmelnikow commented Feb 11, 2020

This won't turn green because Node 8 is still required on the repo. I think we probably can turn it off for the repo once this is merged, though if we want to leave it turned on, I guess we need to leave an empty Node 8 job in this branch.

mastermatt
mastermatt reviewed Feb 11, 2020
View reviewed changes
package.json Outdated
},
"engines": {
"node": ">= 8.0"
"node": ">= 10.0"
Copy link
Copy Markdown
Member

@mastermatt mastermatt Feb 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the idea is to only support LTS, this should be >=10.13.
https://nodejs.org/en/download/releases/

Copy link
Copy Markdown
Member Author

@paulmelnikow paulmelnikow Feb 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think LTS and Active.

Copy link
Copy Markdown
Member

@mastermatt mastermatt Feb 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be supporting LTS Active and Maintenance.
https://nodejs.org/en/about/releases/
Otherwise we'd be dropping 10.x in two months.

Copy link
Copy Markdown
Member Author

@paulmelnikow paulmelnikow Feb 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the ones we support on that chart are Current, Active, and Maintenance. Does that sound right?

@paulmelnikow
Copy link
Copy Markdown
Member Author

paulmelnikow commented Feb 11, 2020

This won't turn green because Node 8 is still required on the repo. I think we probably can turn it off for the repo once this is merged, though if we want to leave it turned on, I guess we need to leave an empty Node 8 job in this branch.

Ah, I can turn it off for the beta branch.

@paulmelnikow paulmelnikow merged commit 864790d into beta Feb 11, 2020
@paulmelnikow paulmelnikow deleted the bump-node branch February 11, 2020 03:58
@paulmelnikow paulmelnikow mentioned this pull request Feb 11, 2020
Closed
@gr2m
Copy link
Copy Markdown
Member

gr2m commented Feb 11, 2020

BREAKING CHANGE is not enough, you need to add a :. I know, tricky one, this happened to me before. But that's the reason why no new release was created for after this merge https://github.com/nock/nock/runs/437745060?check_suite_focus=true#step:5:65

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 11, 2020

🎉 This PR is included in version 11.9.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

mastermatt pushed a commit to mastermatt/nock that referenced this pull request Feb 12, 2020
@paulmelnikow @mastermatt
Require Node 10+ (nock#1895)
6bd426c 
BREAKING CHANGE
paulmelnikow added a commit that referenced this pull request Feb 13, 2020
@paulmelnikow
Require Node 10+ (#1895)
11c0542 
BREAKING CHANGE
@weekly-digest weekly-digest bot mentioned this pull request Feb 16, 2020
Closed
@gr2m gr2m mentioned this pull request Feb 16, 2020
Merged
gr2m pushed a commit that referenced this pull request Feb 16, 2020
@paulmelnikow @gr2m
Require Node 10+ (#1895)
b6794bb 
BREAKING CHANGE: Require Node 10+ (#1895)
gr2m pushed a commit that referenced this pull request Feb 16, 2020
@paulmelnikow @gr2m
Require Node 10+ (#1895)
c5a3b7b 
BREAKING CHANGE: Require Node 10+ (#1895)
gr2m pushed a commit that referenced this pull request Feb 16, 2020
@paulmelnikow @gr2m
Require Node 10+ (#1895)
3e9520a 
BREAKING CHANGE: Require Node 10+ (#1895)
gr2m pushed a commit that referenced this pull request Feb 16, 2020
@paulmelnikow @gr2m
Require Node 10+ (#1895)
dd295cf 
BREAKING CHANGE: Require Node 10+ (#1895)
gr2m pushed a commit that referenced this pull request Feb 16, 2020
@paulmelnikow @gr2m
Require Node 10+ (#1895)
123832e 
BREAKING CHANGE: Require Node 10+ (#1895)
@snyk-bot snyk-bot mentioned this pull request Mar 13, 2020
Merged
This was referenced Mar 26, 2020
Merged
Merged
juninmd pushed a commit to juninmd/nock that referenced this pull request Mar 21, 2026
@paulmelnikow
Require Node 10+ (nock#1895)
2b4b725 
BREAKING CHANGE
juninmd pushed a commit to juninmd/nock that referenced this pull request Mar 21, 2026
@paulmelnikow @gr2m
Require Node 10+ (nock#1895)
a9a4515 
BREAKING CHANGE: Require Node 10+ (nock#1895)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mastermatt mastermatt mastermatt approved these changes

Assignees

No one assigned

Labels

breaking-change released on @beta

Projects

None yet

Milestone

12.x-beta

Development

Successfully merging this pull request may close these issues.

3 participants

@paulmelnikow @gr2m @mastermatt