Skip to content

TypeError in Node 12 #1509

@panva

Description

@panva

A quick heads up, feel free to close once you acknowledge. The test suite does not pass under node 12 (both nock latest and beta channels).

Tested using node nighly build, installed using

NVM_NODEJS_ORG_MIRROR=https://nodejs.org/download/nightly/
nvm i node

Here's the trace i'm getting when pre-testing my modules' test suite relying on nock under node 12, same issue.

TypeError [ERR_INVALID_ARG_TYPE]: The first argument must be one of type string, Buffer, ArrayBuffer, Array, or Array-like Object. Received type function
    at Function.from (buffer.js:218:9)
    at OverriddenClientRequest.RequestOverrider.req.write (/node_modules/nock/lib/request_overrider.js:112:27)
    at OverriddenClientRequest.RequestOverrider.req.end (/node_modules/nock/lib/request_overrider.js:133:11)
    at handleRequest (/node_modules/got/source/request-as-event-emitter.js:211:14)
    at get (/node_modules/got/source/request-as-event-emitter.js:235:5)
    at Immediate.<anonymous> (/node_modules/got/source/request-as-event-emitter.js:306:10)

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions