Skip to content

Help wanted to reach ~100% code coverage #1404

@paulmelnikow

Description

@paulmelnikow

As discussed in #1374 and elsewhere, our current milestone is to reach close to 100% coverage on the beta branch. With 100% test coverage, the tests take on a life of their own in maintaining the project, and will allow us to refactor – and add functionality – with confidence.

@jlilja, @gr2m and I conducted a line-by-line triage and added 46 comments marked TODO-coverage in #1375 and #1380. These are all the spots in the code where work on this milestone is needed.

As of right now we're down to 40, so we're 13% of the way there!

You can help!

  1. Look in the beta branch for TODO-coverage.
  2. Pick a todo or a file to start working on.
  3. Post here, so we don't duplicate any work.
  4. When you're ready, open your pull request on the beta branch.

One bit of guidance: our test strategy is to avoid narrow-bracket tests, and instead aim to keep writing high-level functional tests (i.e. via calls to nock()). If there is not a way to exercise the code through the public nock API, it may be dead code. In the case of dead code, it's better to remove it than to add tests.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions