Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nock/nock
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v11.9.1
Choose a base ref
...
head repository: nock/nock
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v12.0.0
Choose a head ref
  • 10 commits
  • 25 files changed
  • 6 contributors

Commits on Feb 16, 2020

  1. ci: automatically commit and push formatted files (#1882)

    @merlinnot
    merlinnot authored Feb 16, 2020
    Configuration menu
    Copy the full SHA
    858130e View commit details
    Browse the repository at this point in the history

  2. ci: provide issue reference for limited caching configuration (#1908)

    @merlinnot
    merlinnot authored Feb 16, 2020
    Configuration menu
    Copy the full SHA
    d5e4062 View commit details
    Browse the repository at this point in the history

  3. ci: improve consistency and security of the release workflow (#1907)

    @merlinnot
    merlinnot authored Feb 16, 2020
    Configuration menu
    Copy the full SHA
    29eed05 View commit details
    Browse the repository at this point in the history

  4. ci(fix-formatting): avoid error if there are no changes to commit 

    addresses #1883 (comment)
    @gr2m
    gr2m committed Feb 16, 2020
    Configuration menu
    Copy the full SHA
    7fae3c8 View commit details
    Browse the repository at this point in the history

  5. Drop support for String constructor (#1873) 

    BREAKING CHANGE: Drop support for String constructor (#1873)

When checking types of strings, Nock will no longer recognize the String constructor, only string primitives.
    @paulmelnikow @gr2m
    paulmelnikow authored and gr2m committed Feb 16, 2020
    Configuration menu
    Copy the full SHA
    e33b3e8 View commit details
    Browse the repository at this point in the history

  6. Do not return the nock global from cleanAll() (#1872) 

    BREAKING CHANGE: Do not return the `nock` global from `cleanAll()` (#1872)
    @paulmelnikow @gr2m
    paulmelnikow authored and gr2m committed Feb 16, 2020
    Configuration menu
    Copy the full SHA
    0a4a944 View commit details
    Browse the repository at this point in the history

  7. Update mkdirp to the latest version 🚀 (#1857)

    @greenkeeper @gr2m
    greenkeeper[bot] authored and gr2m committed Feb 16, 2020
    Configuration menu
    Copy the full SHA
    70a18b4 View commit details
    Browse the repository at this point in the history

  8. Require Node 10+ (#1895) 

    BREAKING CHANGE: Require Node 10+ (#1895)
    @paulmelnikow @gr2m
    paulmelnikow authored and gr2m committed Feb 16, 2020
    Configuration menu
    Copy the full SHA
    123832e View commit details
    Browse the repository at this point in the history

  9. feat: allow passing a function to enableNetConnect() (#1889) 

    * feat(1861): allow passing a function to enableNetConnect
* Add test to cover passed parameters
    @nikaspran @gr2m
    nikaspran authored and gr2m committed Feb 16, 2020
    Configuration menu
    Copy the full SHA
    7f9e26c View commit details
    Browse the repository at this point in the history

  10. test: Update got to the latest version and fill in missing coverage (#… 

    …1825)

* chore(package): update got to version 10.0.0

* chore(package): update lockfile package-lock.json

* Bump got again and run npm install

* query -> searchParams

* encoding -> responseType

* `{body: …}` no longer implies `.post()`

* auth -> username + password

* query -> searchParams

* Error now has a `response` property

* Couple other fixes

* Restore 100% coverage

* Update lockfile

* refactor(test): use Mocha DSL for allow unmocked (#1894)

* refactor(test): use Mocha DSL for allow unmocked

* Fix format

* baseUrl -> prefixUrl

* Update json’s for breaking changes

* update usage of prefixUrl.

There was a subtle, and I think unnecessary, change in Got 10.x where
using `prefixUrl` means the input, when making a request, can no longer
have a leading slash.
The prefix value can optionally have a trailing slash.
https://github.com/sindresorhus/got#prefixurl

Co-authored-by: Paul Melnikow <github@paulmelnikow.com>
Co-authored-by: Matt R. Wilson <github@mattw.co>
    @greenkeeper @paulmelnikow
    @mastermatt @gr2m
    3 people authored and gr2m committed Feb 16, 2020
    Configuration menu
    Copy the full SHA
    b8dd8c8 View commit details
    Browse the repository at this point in the history
Loading