Implement static executor entities collector#6
Merged
MartinCornelis2 merged 1 commit intonobleo:nobleo/feature/static_executorfrom Mar 26, 2020
Conversation
Signed-off-by: Mauro <mpasserino@irobot.com>
|
This PR also fixes nobleo/static_executor#3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes changes to how the list of entities in the executable list is created and managed.
A new class is created, named StaticExecutorEntitiesCollector, that owns the executable list and has the responsibility to keep it up to date and use it to fill the memory strategy.
The StaticExecutorEntitiesCollector provides methods for refreshing the internal executable list whenever nodes are added or removed from the executor, or entities are added or removed from a node.
This class is derived from the Waitable class. This means that it can be added to an executor that will take care of executing the aforementioned methods whenever its required.
The StaticExecutorEntitiesCollector will wake up the executor whenever one of the following guard conditions is triggered:
This results in refreshing the executable list whenever:
@alsora
@dgoel