Skip to content

feat: lint no_invalid_attributes#209

Merged
noahbald merged 4 commits intomainfrom
feat/lint-no-invalid-attributes
Dec 10, 2025
Merged

feat: lint no_invalid_attributes#209
noahbald merged 4 commits intomainfrom
feat/lint-no-invalid-attributes

Conversation

@noahbald
Copy link
Owner

@noahbald noahbald commented Dec 10, 2025

Description

Creates a new lint that detects when an attribute value is invalid

Motivation and Context

Helps users discover values that may not be usable by a user-agent

How Has This Been Tested?

  • w3c
  • Unit tests
  • Helix

This lint has also uncovered some issues with parsing. That which isn't fixed in this PR will be fixed upstream in lightningcss (parcel-bundler/lightningcss#1106)

Types of changes

Fixes

  • Updates path, d, and points parsing to partially parse partially valid paths, as per spec
  • Updates bbox to allow omitting commas, despite spec
  • Updates startOffset content-type to length-percentage
  • Updates glyph-orientation-horizontal and glyph-orientation-vertical to alow unitless angles

Features

  • Adds new lint
  • Invalid remaining path data included in path type

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@noahbald noahbald self-assigned this Dec 10, 2025
@noahbald noahbald force-pushed the feat/lint-no-invalid-attributes branch from ed37f11 to 09125d3 Compare December 10, 2025 21:29
@noahbald noahbald merged commit c2d0ed0 into main Dec 10, 2025
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant