Skip to content

fix: #184 remove serde from napi#202

Merged
noahbald merged 2 commits intomainfrom
fix/184-remove-serde-from-napi
Dec 2, 2025
Merged

fix: #184 remove serde from napi#202
noahbald merged 2 commits intomainfrom
fix/184-remove-serde-from-napi

Conversation

@noahbald
Copy link
Owner

@noahbald noahbald commented Dec 1, 2025

Description

Disables serde features from napi dependencies.

Note, serde is still a dependency (parcel-bundler/lightningcss#1094), but non-blocking for this PR

Motivation and Context

Reduces bundle-size and runtime performance of napi

How Has This Been Tested?

  • pnpm run test

Types of changes

Features

  • Disables serde features on dependencies
  • Improves typing for SVGO config parser

Regressions

  • Disallows omitted options from SVGO config

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@noahbald noahbald self-assigned this Dec 1, 2025
@noahbald noahbald force-pushed the fix/184-remove-serde-from-napi branch from 3ae11b1 to d3c1f0e Compare December 1, 2025 21:55
@noahbald noahbald merged commit b6f8adc into main Dec 2, 2025
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant