feat: set up linting, lsp, and create new lint no_unknown_attributes lint#199
Merged
feat: set up linting, lsp, and create new lint no_unknown_attributes lint#199
Conversation
noahbald
commented
Nov 28, 2025
| reports: RefCell<Vec<Error<'input>>>, | ||
| } | ||
|
|
||
| impl<'input, 'arena> Visitor<'input, 'arena> for Rules { |
Owner
Author
There was a problem hiding this comment.
Visitor may be overkill. Because linting is immutable, we could instead create a rayon::iter::ParalelIterator over a node's descendants.
2c85a52 to
0b71d56
Compare
0b71d56 to
d30d413
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR does three things
oxvg_lintwith a new ruleno_unknown_attributesoxvg lint checkcommand to run lints on filesoxvg lint servecommand to run a diagnostics lspRunning
oxvg lint checkRunning
oxvg lint servefrom HelixMotivation and Context
This sets up linting as one of the main tools of the oxvg toolchain
How Has This Been Tested?
This can be used in helix with the following language configuration
Types of changes
Fixes
Features
oxvg_lintno_unknown_attributesoxvg lint checkcommandoxvg lint servecommandBreaking changes
Checklist: