Merged
Conversation
noahbald
reviewed
Nov 25, 2025
| tendril::TendrilSink, | ||
| }; | ||
| #[cfg(test)] | ||
| mod tests { |
Owner
There was a problem hiding this comment.
Is mod-ing tests part of clippy? I can't see it in the check's errors
Contributor
Author
There was a problem hiding this comment.
I'm not remember, but to avoid have test code in library, test function are encapsulated in module enabled only on cfg(test)
noahbald
reviewed
Nov 25, 2025
Owner
|
Thanks Gwen for the cleanup, you've been super helpful! |
Owner
|
Don't worry about the deprecated warnings, I still want them for this release but they will be removed in the next |
a944e40 to
db3941c
Compare
warning: unnecessary semicolon help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#unnecessary_semicolon
warning: hiding a lifetime that's elided elsewhere is confusing help: the same lifetime is referred to in inconsistent ways, making the signature confusing
warning: consider adding a `;` to the last statement for consistent formatting help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#semicolon_if_nothing_returned
warning: the following explicit lifetimes could be elided: 'i help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#elidable_lifetime_names
clippy lint msg: manual implementation of `midpoint` which can overflow help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#manual_midpoint
clippy lint msg: this lifetime isn't used in the function definition help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#extra_unused_lifetimes
db3941c to
b64ee3c
Compare
noahbald
approved these changes
Dec 8, 2025
Owner
|
Thanks Gwen, are you happy for me to merge this? |
Contributor
Author
|
Yes you can merge this to at least reduce the number of lints to fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fixe some warning from rustc and clippy
Motivation and Context
clean the code and part of work for avoid failed jobs reported by check workflow :
https://github.com/noahbald/oxvg/actions/runs/19668140313/job/56330008578
How Has This Been Tested?
cargo check/clippy + CI
Types of changes
Checklist: