Conversation
|
I think fixes to the emitted warnings can be completed in a separate PR |
13a3f7a to
6fecea0
Compare
e776b53 to
80c2c88
Compare
this workflow run on each push and pull_request expect on branch with name starting with `wip` to avoid email of failed tasks during test work
'checks' workflow
|
I've just merged #196, would you like to rebase? |
80c2c88 to
4f6d87c
Compare
Done. It's possible to do a fast-forward merge, instead of a commit merge ? And do you prefer to fix the 'report' before integrate this ? Or make the fixes after ? |
yes, feel free to do however you like |
yes, checks should be non blocking (in contrast to build) so we can fix later |
I was talking about the integration into main that you just did with an integration commit 😛. |
After the initial correction phase, I believe that warnings and errors reported by the checks should be fixed before integration, in the same way as build errors. |
|
Yeah I reckon we’ll want to fix them all. It doesn’t need to block other work until then though |
|
I have started some cleanup, my wip work is available in branch https://github.com/gwen-lg/oxvg/tree/wip_improvement |
Extend CI covering but add various checks.
Description
Add formatting, spelling, code and docs checks in Rust workflow.
TODO: don't enable build jobs on push on branches other than
main.Motivation and Context
Improve code and history quality
How Has This Been Tested?
It's need some fix than are in another branch to pass all tests
https://github.com/gwen-lg/oxvg/actions/runs/19345327872/job/55344056631
Types of changes
Fixes
Features
wipChecklist: