Conversation
df201bb to
9715b41
Compare
8ccb25d to
4b20ea2
Compare
bfd4cae to
f78c1fa
Compare
f78c1fa to
c6b45b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current ci fails because napi-rs causes a build error:
undefined symbol: napi_get_globalDescription
Attempts
--no-default-featuresto tests runnercargo/config.tomlld(LLD doesn't handle--warn-unresolved-symbolsthe same as GNU LD rust-lang/rust#147707)no_compiledoctestscompat-modeMotivation and Context
CI should pass so we can continue to have ci/cd and zero-trust deployments to npm
How Has This Been Tested?
ci should pass
Types of changes
Fixes
Features
Breaking changes
RemoveAttrs,PreservePattern, no longer contain a memoOnceLockConvertCase,RemoveUnused,XMLNSOrder,Mode, andExtendsnow haveNapi()variant, to force discriminated unionsGeneratorvariant fromPrefixGenerator.d.tsfile reflects aboveChecklist: