Skip to content

fix: #179 resolve napi ci error#180

Merged
noahbald merged 5 commits intomainfrom
fix/179-fix-napi-ci-error
Oct 27, 2025
Merged

fix: #179 resolve napi ci error#180
noahbald merged 5 commits intomainfrom
fix/179-fix-napi-ci-error

Conversation

@noahbald
Copy link
Owner

@noahbald noahbald commented Sep 23, 2025

Current ci fails because napi-rs causes a build error: undefined symbol: napi_get_global

Description

Attempts

Motivation and Context

CI should pass so we can continue to have ci/cd and zero-trust deployments to npm

How Has This Been Tested?

ci should pass

Types of changes

Fixes

Features

Breaking changes

  • RemoveAttrs, PreservePattern, no longer contain a memo OnceLock
  • ConvertCase, RemoveUnused, XMLNSOrder, Mode, and Extends now have Napi() variant, to force discriminated unions
  • Removed Generator variant from PrefixGenerator
  • napi .d.ts file reflects above

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@noahbald noahbald self-assigned this Sep 23, 2025
@noahbald noahbald force-pushed the fix/179-fix-napi-ci-error branch 2 times, most recently from df201bb to 9715b41 Compare September 23, 2025 05:41
@noahbald noahbald force-pushed the fix/179-fix-napi-ci-error branch 27 times, most recently from 8ccb25d to 4b20ea2 Compare October 27, 2025 11:06
@noahbald noahbald force-pushed the fix/179-fix-napi-ci-error branch 4 times, most recently from bfd4cae to f78c1fa Compare October 27, 2025 11:39
@noahbald noahbald force-pushed the fix/179-fix-napi-ci-error branch from f78c1fa to c6b45b1 Compare October 27, 2025 20:26
@noahbald noahbald marked this pull request as ready for review October 27, 2025 20:39
@noahbald noahbald merged commit 278b5d3 into main Oct 27, 2025
21 checks passed
@noahbald noahbald deleted the fix/179-fix-napi-ci-error branch November 23, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant