Fix the argument order for LedController in LCDemo7Segment#42
Merged
noah1510 merged 1 commit intonoah1510:masterfrom May 30, 2021
Merged
Fix the argument order for LedController in LCDemo7Segment#42noah1510 merged 1 commit intonoah1510:masterfrom
noah1510 merged 1 commit intonoah1510:masterfrom
Conversation
Tested locally on an ESP32 Dev Module and also follows the [documentation](https://ledcontroller.noasakurajin.de/english/d6/df8/classsakurajin_1_1_led_controller.html#ae50febdae23344375a3e3fe8d50cf4f0)
Owner
|
Could you also make the same change in the German version of the Example? That should be easy since they use the same variable names and the examples have the same file name. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested locally on an ESP32 Dev Module and also follows the documentation